refactor!: Standardise CronjobController action names and types#3911
Merged
Mrtenz merged 3 commits intocontroller-refactorsfrom Mar 23, 2026
Merged
refactor!: Standardise CronjobController action names and types#3911Mrtenz merged 3 commits intocontroller-refactorsfrom
CronjobController action names and types#3911Mrtenz merged 3 commits intocontroller-refactorsfrom
Conversation
Mrtenz
commented
Mar 23, 2026
| export const MESSENGER_EXPOSED_METHODS = [ | ||
| // This is used by the `generate-method-action-types` script. | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const MESSENGER_EXPOSED_METHODS = [ |
Member
Author
There was a problem hiding this comment.
This didn't need to be exported.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3911 +/- ##
=======================================================
Coverage ? 98.55%
=======================================================
Files ? 425
Lines ? 12350
Branches ? 1935
=======================================================
Hits ? 12172
Misses ? 178
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames all
CronjobControlleraction and event names and types to follow theController...Actionpattern used in most other controllers.Note
Medium Risk
Primarily a type-level refactor but marked breaking because exported action type names and cronjob exports change; downstream TypeScript code and messenger typings may need updates.
Overview
Standardizes
CronjobControllermessenger action typing. The PR moves cronjob method action definitions into a new auto-generatedCronjobController-method-action-types.ts, renaming the exported action types to theCronjobController…Actionconvention.CronjobControllernow wires its messenger viaregisterMethodActionHandlerswith an explicitMESSENGER_EXPOSED_METHODSlist, and narrows messenger generics by separating controller actions/events from externally allowed ones. Public exports fromcronjob/index.tsare adjusted accordingly, and the changelog is updated to document the new breaking action type names (includingCronjobControllerScheduleAction,CronjobControllerCancelAction,CronjobControllerGetAction).Written by Cursor Bugbot for commit e5867a2. This will update automatically on new commits. Configure here.