refactor!: Update SnapInsightsController to use SnapController:getRunnableSnaps#3915
Merged
Mrtenz merged 3 commits intocontroller-refactorsfrom Mar 24, 2026
Merged
Conversation
| @@ -1 +1,6 @@ | |||
| export * from './SnapInsightsController'; | |||
| export type { | |||
| SnapInsight, | |||
Member
There was a problem hiding this comment.
Is this type used anywhere?
Member
Author
There was a problem hiding this comment.
Part of state, so makes sense to me to export it.
FrederikBolding
approved these changes
Mar 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3915 +/- ##
=======================================================
Coverage ? 98.55%
=======================================================
Files ? 425
Lines ? 12333
Branches ? 1935
=======================================================
Hits ? 12155
Misses ? 178
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
SnapInsightsControllerto useSnapController:getRunnableSnapsinstead ofSnapController:getAllSnaps.Note
Medium Risk
Introduces a breaking change to
SnapInsightsController's messenger dependencies by switching fromSnapController:getAllSnapstoSnapController:getRunnableSnaps, which could affect clients/wiring and which snaps are queried for insights.Overview
SnapInsightsControllernow queries Snaps viaSnapController:getRunnableSnapsinstead of fetching all Snaps and filtering locally, updating its allowed action types accordingly.Tests and controller test-utils were updated to delegate/mock
getRunnableSnaps, and theSignatureControllerstate-change event type was renamed/propagated toSignatureControllerStateChangeEvent. The changelog documents the breaking dependency update, andinsights/index.tsnow uses explicit type/value exports instead ofexport *.Written by Cursor Bugbot for commit 6678cea. This will update automatically on new commits. Configure here.