Skip to content

refactor!: Standardise ExecutionService action names and types#3916

Merged
Mrtenz merged 9 commits intocontroller-refactorsfrom
mrtenz/execution-service-refactor
Mar 24, 2026
Merged

refactor!: Standardise ExecutionService action names and types#3916
Mrtenz merged 9 commits intocontroller-refactorsfrom
mrtenz/execution-service-refactor

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 24, 2026

This renames all ExecutionService action and event names and types to follow the Service...Action pattern used in most other services.


Note

Medium Risk
Breaking API/type changes to ExecutionService and its messenger actions/events may require coordinated updates across consumers; runtime logic is largely moved/renamed but touches snap execution/termination pathways.

Overview
Refactors ExecutionService to match the standard ServiceName...Action / ServiceName...Event naming pattern, including new auto-generated ExecutionService-method-action-types.ts and renamed event types (e.g. ExecutionServiceUnhandledErrorEvent, ExecutionServiceOutboundRequestEvent).

Replaces the old ExecutionService interface + AbstractExecutionService base class by making ExecutionService the abstract base class, updating all concrete implementations (iframe/offscreen/proxy/webview/node) and public exports accordingly, and adjusting tests/simulation/jest helpers to use the new types and messenger handler registration.

Written by Cursor Bugbot for commit deff471. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review March 24, 2026 10:30
@Mrtenz Mrtenz requested a review from a team as a code owner March 24, 2026 10:30
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 94.03974% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (controller-refactors@2b92751). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...snaps-controllers/src/services/ExecutionService.ts 93.52% 9 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             controller-refactors    #3916   +/-   ##
=======================================================
  Coverage                        ?   98.56%           
=======================================================
  Files                           ?      425           
  Lines                           ?    12326           
  Branches                        ?     1935           
=======================================================
  Hits                            ?    12149           
  Misses                          ?      177           
  Partials                        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz force-pushed the mrtenz/execution-service-refactor branch from 1f8b151 to 24b60fc Compare March 24, 2026 13:08
@Mrtenz Mrtenz requested a review from FrederikBolding March 24, 2026 13:16
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

…utionService.ts

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
});

export class ExecutionEnvironmentStub implements ExecutionService {
export class ExecutionEnvironmentStub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used in a place where a ExecutionService is expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but this satisfies ExecutionService.

@Mrtenz Mrtenz merged commit 95d127d into controller-refactors Mar 24, 2026
127 checks passed
@Mrtenz Mrtenz deleted the mrtenz/execution-service-refactor branch March 24, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants