refactor!: Standardise ExecutionService action names and types#3916
Merged
Mrtenz merged 9 commits intocontroller-refactorsfrom Mar 24, 2026
Merged
refactor!: Standardise ExecutionService action names and types#3916Mrtenz merged 9 commits intocontroller-refactorsfrom
ExecutionService action names and types#3916Mrtenz merged 9 commits intocontroller-refactorsfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3916 +/- ##
=======================================================
Coverage ? 98.56%
=======================================================
Files ? 425
Lines ? 12326
Branches ? 1935
=======================================================
Hits ? 12149
Misses ? 177
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1f8b151 to
24b60fc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/snaps-controllers/src/services/node-js/NodeThreadExecutionService.ts
Outdated
Show resolved
Hide resolved
…utionService.ts Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
| }); | ||
|
|
||
| export class ExecutionEnvironmentStub implements ExecutionService { | ||
| export class ExecutionEnvironmentStub { |
Member
There was a problem hiding this comment.
Is this not used in a place where a ExecutionService is expected?
Member
Author
There was a problem hiding this comment.
It is, but this satisfies ExecutionService.
FrederikBolding
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This renames all
ExecutionServiceaction and event names and types to follow theService...Actionpattern used in most other services.Note
Medium Risk
Breaking API/type changes to
ExecutionServiceand its messenger actions/events may require coordinated updates across consumers; runtime logic is largely moved/renamed but touches snap execution/termination pathways.Overview
Refactors
ExecutionServiceto match the standardServiceName...Action/ServiceName...Eventnaming pattern, including new auto-generatedExecutionService-method-action-types.tsand renamed event types (e.g.ExecutionServiceUnhandledErrorEvent,ExecutionServiceOutboundRequestEvent).Replaces the old
ExecutionServiceinterface +AbstractExecutionServicebase class by makingExecutionServicethe abstract base class, updating all concrete implementations (iframe/offscreen/proxy/webview/node) and public exports accordingly, and adjusting tests/simulation/jest helpers to use the new types and messenger handler registration.Written by Cursor Bugbot for commit deff471. This will update automatically on new commits. Configure here.