refactor: Refactor WebSocketService to use messenger exposed methods#3917
Merged
Mrtenz merged 3 commits intocontroller-refactorsfrom Mar 25, 2026
Merged
refactor: Refactor WebSocketService to use messenger exposed methods#3917Mrtenz merged 3 commits intocontroller-refactorsfrom
WebSocketService to use messenger exposed methods#3917Mrtenz merged 3 commits intocontroller-refactorsfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3917 +/- ##
=======================================================
Coverage ? 98.56%
=======================================================
Files ? 425
Lines ? 12323
Branches ? 1935
=======================================================
Hits ? 12146
Misses ? 177
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @throws If the connection fails. | ||
| */ | ||
| async #open(snapId: SnapId, url: string, protocols: string[] = []) { | ||
| async open(snapId: SnapId, url: string, protocols: string[] = []) { |
Member
There was a problem hiding this comment.
Hmm, do we strictly need methods available publicly on the service class itself?
Member
Author
There was a problem hiding this comment.
Yes, since they are referenced in the generated types file.
FrederikBolding
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the
WebSocketServiceto use the messenger exposed methods.Note
Medium Risk
Moderate risk because it changes how
WebSocketServiceactions are registered/exposed on the messenger and makes previously private methods public, which could break callers relying on old action types or handler names.Overview
Refactors
WebSocketServiceto register messenger actions viaregisterMethodActionHandlersusing an explicitMESSENGER_EXPOSED_METHODSlist, replacing per-actionregisterActionHandlerwiring.Adds an auto-generated
WebSocketService-method-action-types.tsfile for strongly-typed method action definitions, updatesWebSocketServiceto use these types, and adjusts exports inwebsocket/index.tsto export the service class plus selected types (instead ofexport *).Written by Cursor Bugbot for commit 44b0f39. This will update automatically on new commits. Configure here.