Skip to content

chore!: Remove active references from SnapController#3920

Merged
Mrtenz merged 3 commits intocontroller-refactorsfrom
mrtenz/remove-active-references
Mar 25, 2026
Merged

chore!: Remove active references from SnapController#3920
Mrtenz merged 3 commits intocontroller-refactorsfrom
mrtenz/remove-active-references

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 25, 2026

This removes activeReferences from the Snap runtime data, including the methods to increment and decrement it. This was never used in production.


Note

Medium Risk
Removes public SnapController APIs (incrementActiveReferences/decrementActiveReferences) and drops the activeReferences runtime guard, which could change idle-time termination behavior for any downstream code that relied on keeping snaps alive.

Overview
Removes activeReferences tracking from SnapController runtime data, including deleting the incrementActiveReferences/decrementActiveReferences methods and the associated idle-timeout exclusion.

Updates tests by removing the scenario that asserted snaps with open sessions are not terminated, and documents the breaking removal in the snaps-controllers changelog.

Written by Cursor Bugbot for commit f4474b4. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review March 25, 2026 11:09
@Mrtenz Mrtenz requested a review from a team as a code owner March 25, 2026 11:09
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (controller-refactors@75f65f4). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             controller-refactors    #3920   +/-   ##
=======================================================
  Coverage                        ?   98.56%           
=======================================================
  Files                           ?      425           
  Lines                           ?    12315           
  Branches                        ?     1934           
=======================================================
  Hits                            ?    12138           
  Misses                          ?      177           
  Partials                        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz requested a review from FrederikBolding March 25, 2026 11:40
@Mrtenz Mrtenz merged commit ba6c56a into controller-refactors Mar 25, 2026
127 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-active-references branch March 25, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants