chore!: Remove active references from SnapController#3920
Merged
Mrtenz merged 3 commits intocontroller-refactorsfrom Mar 25, 2026
Merged
chore!: Remove active references from SnapController#3920Mrtenz merged 3 commits intocontroller-refactorsfrom
SnapController#3920Mrtenz merged 3 commits intocontroller-refactorsfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3920 +/- ##
=======================================================
Coverage ? 98.56%
=======================================================
Files ? 425
Lines ? 12315
Branches ? 1934
=======================================================
Hits ? 12138
Misses ? 177
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
activeReferencesfrom the Snap runtime data, including the methods to increment and decrement it. This was never used in production.Note
Medium Risk
Removes public
SnapControllerAPIs (incrementActiveReferences/decrementActiveReferences) and drops theactiveReferencesruntime guard, which could change idle-time termination behavior for any downstream code that relied on keeping snaps alive.Overview
Removes
activeReferencestracking fromSnapControllerruntime data, including deleting theincrementActiveReferences/decrementActiveReferencesmethods and the associated idle-timeout exclusion.Updates tests by removing the scenario that asserted snaps with open sessions are not terminated, and documents the breaking removal in the
snaps-controllerschangelog.Written by Cursor Bugbot for commit f4474b4. This will update automatically on new commits. Configure here.