Skip to content

chore: Standardise controller/service exports#3921

Merged
Mrtenz merged 3 commits intocontroller-refactorsfrom
mrtenz/standardise-exports
Mar 25, 2026
Merged

chore: Standardise controller/service exports#3921
Mrtenz merged 3 commits intocontroller-refactorsfrom
mrtenz/standardise-exports

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 25, 2026

Note

Low Risk
Primarily TypeScript type/export refactors; runtime behavior should be unchanged, but downstream packages may require import/type updates due to renamed or newly exported messenger/action/event types.

Overview
Standardizes public exports across snaps-controllers by re-exporting each controller/service’s *Args, *Actions, *Events, and *Messenger types (e.g., CronjobController, SnapInsightsController, SnapInterfaceController, MultichainRoutingService, ExecutionService, SnapController).

Tightens internal messenger typing by making previously exported AllowedActions/AllowedEvents helper unions internal (renamed to local Allowed* types) and updating snaps-simulation to use the concrete *Messenger types and a strongly-typed RootControllerMessenger based on @metamask/messenger’s MessengerActions/MessengerEvents.

Written by Cursor Bugbot for commit e1c676d. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (controller-refactors@89b1675). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             controller-refactors    #3921   +/-   ##
=======================================================
  Coverage                        ?   98.56%           
=======================================================
  Files                           ?      425           
  Lines                           ?    12313           
  Branches                        ?     1934           
=======================================================
  Hits                            ?    12136           
  Misses                          ?      177           
  Partials                        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review March 25, 2026 13:19
@Mrtenz Mrtenz requested a review from a team as a code owner March 25, 2026 13:19
@Mrtenz Mrtenz merged commit c038fb4 into controller-refactors Mar 25, 2026
127 checks passed
@Mrtenz Mrtenz deleted the mrtenz/standardise-exports branch March 25, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants