Skip to content

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Aug 29, 2024

This PR backports Android performance improvements from v10 to an upcoming v9.0.10.

This should not be merged into main as rc-v10 has already been merged. We will simply publish this branch.

Related: #293

@infiniteflower
Copy link
Contributor Author

This is ready to be reviewed

@infiniteflower infiniteflower marked this pull request as ready for review August 29, 2024 17:07
@infiniteflower infiniteflower requested a review from a team August 29, 2024 17:07
@infiniteflower
Copy link
Contributor Author

infiniteflower commented Aug 29, 2024

Conflicts with main don't matter as this was branched off of fcc2010 (9.0.9). The code diff is against 9.0.9.

@legobeat legobeat changed the base branch from main to v9.x August 29, 2024 19:36
@legobeat
Copy link
Contributor

legobeat commented Aug 29, 2024

This should not be merged into main as rc-v10 has already been merged. We will simply publish this branch.

In order to keep things managable in event of future backports, I propose a long-living 9.x branch to publish from after merge into it. WDYT?

I just created a 9.x branch from 9.0.9 and changed the base on this PR to it. Then should also be mergable without conflicts.

@infiniteflower
Copy link
Contributor Author

This should not be merged into main as rc-v10 has already been merged. We will simply publish this branch.

In order to keep things managable in event of future backports, I propose a long-living 9.x branch to publish from after merge into it. WDYT?

I just created a 9.x branch from 9.0.9 and changed the base on this PR to it. Then should also be mergable without conflicts.

Thanks @legobeat great idea! I'll merge into that branch then.

@infiniteflower infiniteflower merged commit 2fe2240 into v9.x Aug 29, 2024
@infiniteflower infiniteflower deleted the chore/android-perf-2 branch August 29, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants