-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/android startup times remove web3 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/android startup times remove web3 #293
Conversation
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/ws@7.4.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Was not able to test with Android device but tested for basic regressions on iOs as instructed
* chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * chore: remove web3 package * chore: add @ethersproject/contracts * chore: add @ethersproject/providers * chore: remove web3 and use ethers contracts instead * fix: broken tests --------- Co-authored-by: nikoferro <nicolaspatricioferro@gmail.com> Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
* chore: updating dependencies to match mobile current versions (#271) * chore: refactor SwapsController so it extends from BaseControllerV2 (#280) * chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * fix: remove any types and improve util types * fix: removes type cast that is no longer needed Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Marta Poling <marta.hourigan.johnson@gmail.com> * Fix/android startup times remove web3 (#293) * chore: updating dependencies to match mobile current versions * feat: basecontrollerv2 refactor * fix: linter fix * fix: test fix * chore: exposing types of actions and events * fix: removing provider from state since its not serializable * fix: fix for resetting state while keeping the current chain and last fetched config * chore: export controller types * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/constants.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/swapsUtil.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/types.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * Update src/SwapsController.ts Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: pr feedback changes * chore: make explicit which properties are already anonymous * chore: default value for state as an optional parameter * chore: remove web3 package * chore: add @ethersproject/contracts * chore: add @ethersproject/providers * chore: remove web3 and use ethers contracts instead * fix: broken tests --------- Co-authored-by: nikoferro <nicolaspatricioferro@gmail.com> Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> * chore: update yarn lock after fixing merge conflicts * chore: update syntax for linter * chore: pin version of ethersproject dependency ws due to high security vulnerability status --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Marta Poling <marta.hourigan.johnson@gmail.com> Co-authored-by: infiniteflower <139582705+infiniteflower@users.noreply.github.com>
This PR removes Web3 in favor of just using Ethers to read values off a contract.
App start and Logcat are 2 related but different measurements. Logcat is more closely related to visually looking at the app and seeing when it starts up.
Related issues:
Manual testing steps
Refer to MetaMask/metamask-mobile#10787 for steps on how to test