chore: bump @metamask/{transaction, approval}-controller
#333
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
This package is ours |
| "@metamask/transaction-controller": "^37.3.0", | ||
| "@types/jest": "^26.0.22", | ||
| "@types/node": "^20.10.4", | ||
| "@types/readable-stream": "^4.0.18", |
There was a problem hiding this comment.
added to fix several error messages similar to these ones:
node_modules/@metamask/object-multiplex/dist/ObjectMultiplex.d.ts:2:44 - error TS7016: Could not find a declaration file for module 'readable-stream'
node_modules/@metamask/post-message-stream/dist/BasePostMessageStream.d.ts:1:24 - error TS7016: Could not find a declaration file for module 'readable-stream'. '/home/mike/dev/metamask/swaps-controller/node_modules/readable-stream/readable.js' implicitly has an 'any' type.
Try `npm i --save-dev @types/readable-stream` if it exists or add a new declaration (.d.ts) file containing `declare module 'readable-stream';`
1 import { Duplex } from 'readable-stream';
There was a problem hiding this comment.
It seems that @types/readable-stream is a dev dependency of @metamask/object-multiplex when it should not be in the dev group. I've added a ticket for this here: MetaMask/object-multiplex#58
| "@metamask/eslint-config-nodejs": "^12.1.0", | ||
| "@metamask/eslint-config-typescript": "^12.1.0", | ||
| "@metamask/gas-fee-controller": "^21.0.0", | ||
| "@metamask/keyring-controller": "^17.0.0", |
There was a problem hiding this comment.
added to fix this error yield by AccountsController:
node_modules/@metamask/accounts-controller/dist/utils.d.cts:1:30 - error TS2307: Cannot find module '@metamask/keyring-controller' or its corresponding type declarations.
1 import { KeyringTypes } from "@metamask/keyring-controller";There was a problem hiding this comment.
Connected to the @metamask/transaction-controller update, I see.
| "@babel/runtime": "^7.0.0", | ||
| "@lavamoat/allow-scripts": "^3.0.0", | ||
| "@metamask/approval-controller": "^5.1.1", | ||
| "@metamask/accounts-controller": "^18.0.0", |
There was a problem hiding this comment.
required by this TransactionController version:
node_modules/@metamask/transaction-controller/dist/TransactionController.d.cts:3:65 - error TS2307: Cannot find module '@metamask/accounts-controller' or its corresponding type declarations.
3 import type { AccountsControllerGetSelectedAccountAction } from "@metamask/accounts-controller";
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@metamask/transaction-controller/dist/helpers/IncomingTransactionHelper.d.cts:2:41 - error TS2307: Cannot find module '@metamask/accounts-controller' or its corresponding type declarations.
2 import type { AccountsController } from "@metamask/accounts-controller";There was a problem hiding this comment.
It looks like we only use @metamask/transaction-controller for types and yet this is needed because TransactionController talks to AccountsController, so @metamask/accounts-controller is a peer dependency of @metamask/transaction-controller. Interesting.
New authors seem to be trusted These are ours |
| "@metamask/eslint-config-nodejs": "^12.1.0", | ||
| "@metamask/eslint-config-typescript": "^12.1.0", | ||
| "@metamask/gas-fee-controller": "^21.0.0", | ||
| "@metamask/keyring-controller": "^17.0.0", |
There was a problem hiding this comment.
Connected to the @metamask/transaction-controller update, I see.
| "@babel/runtime": "^7.0.0", | ||
| "@lavamoat/allow-scripts": "^3.0.0", | ||
| "@metamask/approval-controller": "^5.1.1", | ||
| "@metamask/accounts-controller": "^18.0.0", |
There was a problem hiding this comment.
It looks like we only use @metamask/transaction-controller for types and yet this is needed because TransactionController talks to AccountsController, so @metamask/accounts-controller is a peer dependency of @metamask/transaction-controller. Interesting.
| "@metamask/transaction-controller": "^37.3.0", | ||
| "@types/jest": "^26.0.22", | ||
| "@types/node": "^20.10.4", | ||
| "@types/readable-stream": "^4.0.18", |
There was a problem hiding this comment.
It seems that @types/readable-stream is a dev dependency of @metamask/object-multiplex when it should not be in the dev group. I've added a ticket for this here: MetaMask/object-multiplex#58
2 participants
See changelogs for details on changes we are pulling in: