chore: bump @metamask/{transaction, approval}-controller
#333
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,18 +39,21 @@ | |
| "devDependencies": { | ||
| "@babel/runtime": "^7.0.0", | ||
| "@lavamoat/allow-scripts": "^3.0.0", | ||
| "@metamask/accounts-controller": "^18.0.0", | ||
| "@metamask/approval-controller": "^7.1.0", | ||
| "@metamask/auto-changelog": "^3.4.4", | ||
| "@metamask/composable-controller": "^9.0.1", | ||
| "@metamask/eslint-config": "^12.2.0", | ||
| "@metamask/eslint-config-jest": "^12.1.0", | ||
| "@metamask/eslint-config-nodejs": "^12.1.0", | ||
| "@metamask/eslint-config-typescript": "^12.1.0", | ||
| "@metamask/gas-fee-controller": "^21.0.0", | ||
| "@metamask/keyring-controller": "^17.0.0", | ||
|
There was a problem hiding this comment. added to fix this error yield by node_modules/@metamask/accounts-controller/dist/utils.d.cts:1:30 - error TS2307: Cannot find module '@metamask/keyring-controller' or its corresponding type declarations.
1 import { KeyringTypes } from "@metamask/keyring-controller";There was a problem hiding this comment. Connected to the |
||
| "@metamask/network-controller": "^21.1.0", | ||
| "@metamask/transaction-controller": "^37.3.0", | ||
| "@types/jest": "^26.0.22", | ||
| "@types/node": "^20.10.4", | ||
| "@types/readable-stream": "^4.0.18", | ||
|
There was a problem hiding this comment. added to fix several error messages similar to these ones: node_modules/@metamask/object-multiplex/dist/ObjectMultiplex.d.ts:2:44 - error TS7016: Could not find a declaration file for module 'readable-stream'
node_modules/@metamask/post-message-stream/dist/BasePostMessageStream.d.ts:1:24 - error TS7016: Could not find a declaration file for module 'readable-stream'. '/home/mike/dev/metamask/swaps-controller/node_modules/readable-stream/readable.js' implicitly has an 'any' type.
Try `npm i --save-dev @types/readable-stream` if it exists or add a new declaration (.d.ts) file containing `declare module 'readable-stream';`
1 import { Duplex } from 'readable-stream';There was a problem hiding this comment. It seems that |
||
| "@typescript-eslint/eslint-plugin": "^5.42.1", | ||
| "@typescript-eslint/parser": "^5.42.1", | ||
| "babel-runtime": "^6.26.0", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required by this
TransactionControllerversion:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we only use
@metamask/transaction-controllerfor types and yet this is needed because TransactionController talks to AccountsController, so@metamask/accounts-controlleris a peer dependency of@metamask/transaction-controller. Interesting.