Clean up dependencies

[mcmire]

• Move @metamask/gas-fee-controller and @metamask/network-controller from peerDependencies to dependencies, as neither of them are being used for communication
• Remove unused dev dependencies @metamask/composable-controller, @types/readable-stream, jest-environment-jsdoc, and ts-node as they were not being used
• Replace rimraf with a shell command

---

This is a cleanup task that I'd like to get in before releasing the next major version.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@cspotcode/source-map-support@0.8.1, npm/@metamask/composable-controller@9.0.1, npm/@tootallnate/once@2.0.0, npm/@tsconfig/node10@1.0.11, npm/@tsconfig/node12@1.0.11, npm/@tsconfig/node14@1.0.3, npm/@tsconfig/node16@1.0.4, npm/@types/jsdom@20.0.1, npm/@types/readable-stream@4.0.18, npm/@types/tough-cookie@4.0.5, npm/abab@2.0.6, npm/acorn-globals@7.0.1, npm/acorn-walk@8.3.3, npm/arg@4.1.3, npm/asynckit@0.4.0, npm/combined-stream@1.0.8, npm/create-require@1.1.1, npm/cssom@0.5.0, npm/cssstyle@2.3.0, npm/data-urls@3.0.2, npm/decimal.js@10.4.3, npm/delayed-stream@1.0.0, npm/domexception@4.0.0, npm/entities@4.5.0, npm/escodegen@2.1.0, npm/form-data@4.0.0, npm/html-encoding-sniffer@3.0.0, npm/is-potential-custom-element-name@1.0.1, npm/jest-environment-jsdom@29.7.0, npm/jsdom@20.0.3, npm/mime-db@1.52.0, npm/mime-types@2.1.35, npm/nwsapi@2.2.12, npm/psl@1.9.0, npm/querystringify@2.2.0, npm/requires-port@1.0.0, npm/safe-buffer@5.1.2, npm/saxes@6.0.0, npm/symbol-tree@3.2.4, npm/tough-cookie@4.1.4, npm/tr46@3.0.0, npm/ts-node@10.9.2, npm/universalify@0.2.0, npm/url-parse@1.5.10, npm/v8-compile-cache-lib@3.0.1, npm/w3c-xmlserializer@4.0.0, npm/webidl-conversions@7.0.0, npm/whatwg-encoding@2.0.0, npm/whatwg-mimetype@3.0.0, npm/whatwg-url@11.0.0, npm/xml-name-validator@4.0.0, npm/xmlchars@2.2.0, npm/yn@3.1.1

View full report↗︎

[cryptodev-2s]

Approved just a question why are we replacing rimraf with rm -rf which wouldn't work with windows machines unless or course git bash or other tooling is used ...

[mcmire]

Alright, I can submit another to revert this change.

[mcmire]

Change reverted: #376

[Gudahtt]

Move @metamask/gas-fee-controller and @metamask/network-controller from peerDependencies to dependencies, as neither of them are being used for communication

Hmm, unfortunately I don't think this is true, they are both used for communication. The former is used not via the messenger, but the fetchGasFeeEstimates constructor parameter. And the latter is used in the messenger directly, which you may have missed because it's in the types.ts file.

[mcmire]

@Gudahtt Ah... you're right, thanks. I will add those packages back to dev + peerDependencies.