Skip to content

Clean up dependencies #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Clean up dependencies #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **BREAKING:** Update type of `fetchEstimatedMultiLayerL1Fee` in `SwapsControllerOptions` by replacing `chainId` in `options` with `networkClientId` ([#347](https://github.com/MetaMask/swaps-controller/pull/347))
- The chain cache in state will now automatically be updated whenever the network has changed ([#347](https://github.com/MetaMask/swaps-controller/pull/347))
- This aims to replace behavior provided by `setProvider` and `setChainId`.
- Move `@metamask/gas-fee-controller` from `peerDependencies` to `dependencies` and upgrade to `^22.0.2` ([#369](https://github.com/MetaMask/swaps-controller/pull/369))
- Move `@metamask/network-controller` from `peerDependencies` to `dependencies` and upgrade to `^22.1.0` ([#369](https://github.com/MetaMask/swaps-controller/pull/369))

### Removed

Expand Down
16 changes: 3 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,32 +27,23 @@
"lint": "yarn lint:eslint && yarn lint:misc --check",
"lint:changelog": "auto-changelog validate --prettier",
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write",
"build:clean": "rimraf dist && yarn build",
"build:clean": "rm -rf dist && yarn build",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved just a question why are we replacing rimraf with rm -rf which wouldn't work with windows machines unless or course git bash or other tooling is used ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I can submit another to revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change reverted: #376

"build": "tsc --project .",
"prepack": "./scripts/prepack.sh"
},
"peerDependencies": {
"@metamask/composable-controller": "^9.0.1",
"@metamask/gas-fee-controller": "^22.0.0",
"@metamask/network-controller": "^22.0.0"
},
"devDependencies": {
"@babel/runtime": "^7.0.0",
"@ethersproject/abi": "^5.7.0",
"@lavamoat/allow-scripts": "^3.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/composable-controller": "^9.0.1",
"@metamask/eslint-config": "^12.2.0",
"@metamask/eslint-config-jest": "^12.1.0",
"@metamask/eslint-config-nodejs": "^12.1.0",
"@metamask/eslint-config-typescript": "^12.1.0",
"@metamask/eth-json-rpc-provider": "^4.1.6",
"@metamask/gas-fee-controller": "^22.0.2",
"@metamask/json-rpc-engine": "^10.0.1",
"@metamask/network-controller": "^22.1.0",
"@types/jest": "^29.5.14",
"@types/node": "^20.10.4",
"@types/readable-stream": "^4.0.18",
"@typescript-eslint/eslint-plugin": "^5.42.1",
"@typescript-eslint/parser": "^5.42.1",
"@yarnpkg/types": "^4.0.0",
Expand All @@ -67,11 +58,8 @@
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.1.1",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"prettier": "^2.2.1",
"rimraf": "^3.0.2",
"ts-jest": "^29.1.1",
"ts-node": "^10.9.1",
"typescript": "^5.1.0"
},
"dependencies": {
Expand All @@ -80,6 +68,8 @@
"@metamask/base-controller": "^7.0.1",
"@metamask/controller-utils": "^11.3.0",
"@metamask/eth-query": "^4.0.0",
"@metamask/gas-fee-controller": "^22.0.2",
"@metamask/network-controller": "^22.1.0",
"@metamask/utils": "^10.0.0",
"async-mutex": "^0.5.0",
"bignumber.js": "^9.0.1",
Expand Down
Loading
Loading