Merged
Conversation
ieow
reviewed
Jun 8, 2023
| const tb2 = new ThresholdKey({ serviceProvider: customSP, storageLayer: customSL, manualSync: mode }); | ||
| await tb2.initialize({ neverInitializeNewKey: true }); | ||
| tb2.inputShareStore(resp1.deviceShare); | ||
| await tb2.inputShareStoreSafe(resp1.deviceShare); |
Contributor
There was a problem hiding this comment.
are we deprecating inputShareStore and use only inputShareStoreSafe for all usage ?
if so, we can check for if polynomial_id is equal with the tkey's latest polynomial and update it without catchupToLatestShare.
Contributor
There was a problem hiding this comment.
hmm, we should make inputShareStore internal or mark internal somehow. With existence of core kit, tkey has more room to be "swiss army knife"
ieow
reviewed
Jun 8, 2023
| const latestShareRes = await this.catchupToLatestShare({ shareStore: ss, includeLocalMetadataTransitions: true }); | ||
| // if not in poly id list, metadata is probably outdated | ||
| // is !this.metadata.polyIDList.includes(latestShareRes.latestShare.polynomialID) | ||
| if (!latestShareRes.shareMetadata.polyIDList.find((tuple) => tuple[0] === this.metadata.getLatestPublicPolynomial().getPolynomialID())) { |
Contributor
There was a problem hiding this comment.
move this before the comment as the comment are meant for line 821
can add comment for this new code checking
check if the latest share is part of the current tkey instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.