Skip to content

Sapphire Support & Import Private Key #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaitanyapotti merged 248 commits into from
Aug 30, 2024
Merged

Sapphire Support & Import Private Key #28

chaitanyapotti merged 248 commits into from
Aug 30, 2024

Conversation

@grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Aug 5, 2024 •
edited by metalurgical
Loading

Screenshot 2024-08-15 at 22 56 17

grvgoel81 added 30 commits June 1, 2023 16:28
@grvgoel81
Removed unnecessary code and updated pojos for retrive shares and con…
e5b5b11 
…structor
@grvgoel81
adding POJOS for retreive shares
6d0c5a4
@grvgoel81
modified pubKey changes
1f35528
@grvgoel81
refactored getPublicKey function
401dce0
@grvgoel81
refactored retriveShares function
027c18f
@grvgoel81
refactored retriveShares function
96926f3
@grvgoel81
refactored retriveShares function
94200e7
@grvgoel81
Added SapphireTest case for getPublicAddress function
f5ea0ee
@grvgoel81
changes in ShareRequestParams
c3af4ac
@grvgoel81
changes added for KeyAssignResult
59c5fdc
@grvgoel81
changes added for retrieveShares
0148da2
@grvgoel81
changes added for KeyAssignment
5872a79
@grvgoel81
changes added for RetrieveSharesResponse,
1b044d8 
modify GetKeyOrShareAssign
@grvgoel81
testcase added for GetKeyAssign
7e27116
@grvgoel81
importShares params added in ImportShares request
a5520c2
@grvgoel81
LEGACY_NETWORKS_ROUTE_MAP support added in getPublicAddress() and ret…
06df790 
…riveShare() function
@grvgoel81
Added SapphireTestcases for getPublicAddress and retrieveShare functions
eb58b21
@grvgoel81
added legacyPublicAddress and keyAssign() function and improve testcases
d1f610f
@grvgoel81
testcases refactored for mainnet network
d0a28dc
@grvgoel81
testcases refactored for TorusUtilsTest
0d9b92a
@grvgoel81
code refactored
94a7275
@grvgoel81
code refactored
df4c77b
@grvgoel81
retrieveShares() code refactored to support legacy network functions.
7182ee9
@grvgoel81
Refractored onekeytest and MainnetTest
f51c66c
@grvgoel81
code refactored
3b904b3
@grvgoel81
Aqua, cyan and celeste test cases refactored
a2c7024
@grvgoel81
MainnetTest cases refactored
a4acf09
@grvgoel81
getUserTypeAndAddress function and test cases added
8b74e03
@grvgoel81
code refactoring
5a30138
@grvgoel81
Updated RetrieveSharesResponse and modified test cases.
8568e5b
@metalurgical
update
de46f34 
fix: edge case for padding public keys
fix: explicitly check that imported private key matches the final derived private key
fix: improve test stability
@metalurgical
update
8cd30d2
@metalurgical
further improve test stability
3416099 
additionally save configuration to run all tests
@metalurgical
update: rename test configuration file
0192001
@metalurgical
cleanup
aad3fab
@metalurgical metalurgical changed the title Import private key Sapphire Support and Import private key Aug 15, 2024
@metalurgical metalurgical changed the title Sapphire Support and Import private key Sapphire Support & Import private key Aug 15, 2024
@metalurgical metalurgical changed the title Sapphire Support & Import private key Sapphire Support & Import Private Key Aug 15, 2024
grvgoel81 and others added 6 commits August 16, 2024 09:40
@grvgoel81
cleanup and add unit-tests
ee62e69 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@metalurgical
add missing try...catch for CompletableFuture results
b016b37
@metalurgical
cleanup warnings
27e38d3
@grvgoel81
code cleanup
2993d5f 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
Merge remote-tracking branch 'origin/import_private_key' into import_…
4f11b80 
…private_key
@grvgoel81
code cleanup
44f8a41 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81 grvgoel81 requested a review from metalurgical August 23, 2024 04:22
chaitanyapotti
chaitanyapotti reviewed Aug 26, 2024
View reviewed changes
chaitanyapotti
chaitanyapotti reviewed Aug 30, 2024
View reviewed changes
src/main/java/org/torusresearch/torusutils/helpers/NodeUtils.java
Gson json = new Gson();
for (CompletableFuture<String> lookup: lookupPromises) {
try {
String result = lookup.get();
Copy link
Member

@chaitanyapotti chaitanyapotti Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is your replacement for some.. is it?

Copy link
Contributor

@metalurgical metalurgical Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Ideally should be Future instead of CompletableFuture, since the former is cancellable

chaitanyapotti
chaitanyapotti approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 8c057df into master Aug 30, 2024
@chaitanyapotti chaitanyapotti deleted the import_private_key branch August 30, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metalurgical metalurgical Awaiting requested review from metalurgical

1 more reviewer

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grvgoel81 @metalurgical @chaitanyapotti