feat: add Citadel record id and login outcome query params#184
Merged
chaitanyapotti merged 3 commits intomasterfrom Mar 25, 2026
Merged
feat: add Citadel record id and login outcome query params#184chaitanyapotti merged 3 commits intomasterfrom
chaitanyapotti merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
hieu-w
previously approved these changes
Mar 25, 2026
Drop the TorusLoginStatus enum and the torusloginstatus query string from Citadel allow URLs. Login lifecycle is reported only via the boolean toruslogininitiated / torusloginsuccess / torusloginfailed params.
arch1995
previously approved these changes
Mar 25, 2026
hieu-w
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Jira Link
Description
crypto.randomUUID()and pass it throughretrieveOrImportShareand the Citadel allow flow.recordidto the Citadel signer allow URL (buildAllowUrl).toruslogininitiated,torusloginsuccess,torusloginfailed, aligned with existingtorusloginstatusreporting.recordIdandtorusLoginInitiated: true; on success/failure, set the corresponding boolean flags when callingreportSignerAllow.How has this been tested?
Screenshots (if appropriate)
N/A (no UI changes).
Types of changes
Checklist
Note
Medium Risk
Touches the
retrieveOrImportShare/Citadel allow reporting path and changes required params (newrecordIdplus new query flags), which could impact login telemetry or fail in runtimes withoutcrypto.randomUUID().Overview
Adds a per-login
recordId(generated viacrypto.randomUUID()) and includes it asrecordidon Citadel signer allow requests, threading the value throughTorus.retrieveShares/importPrivateKeyintoretrieveOrImportShare.Replaces the single
torusloginstatusenum with three optional boolean query params (toruslogininitiated,torusloginsuccess,torusloginfailed) and updates allow reporting to send initiated at share retrieval start and success/failure on completion.Written by Cursor Bugbot for commit bcffca9. This will update automatically on new commits. Configure here.