[RTM 2] Use Utf8::toAscii instead of \utf8_romanize (fixes plenty deprecation hints)#9
Merged
stefanheimes merged 2 commits intoMetaModels:masterfrom Feb 16, 2020
Merged
Conversation
richardhj
approved these changes
Oct 1, 2019
Member
richardhj
left a comment
richardhj
left a comment
There was a problem hiding this comment.
Travis will fail as of malicious Code Style (space) but good besides this.
discordier
approved these changes
Oct 1, 2019
zonky2
changed the title
Contributor
|
@stefanheimes merge this #11 as first |
zonky2
changed the title
discordier
added a commit
that referenced
this pull request
Feb 10, 2020
This changes `\utf8_romanize` calls to `Utf8::toAscii` and therefore fixes plenty of deprecations.
Member
|
Merged in c0dc54b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global helper functions are all marked deprecated. This PR fixes plenty deprecation hints by using the advised alternative of Patchwork\Utf8.