Skip to content

[RTM] hotfix cast empty value as zero#63

Merged
stefanheimes merged 1 commit intomasterfrom
hotfix_cast_empty_as_zero
Jun 19, 2018
Merged

[RTM] hotfix cast empty value as zero#63
stefanheimes merged 1 commit intomasterfrom
hotfix_cast_empty_as_zero

Conversation

@zonky2
Copy link
Copy Markdown
Contributor

@zonky2 zonky2 commented Jun 8, 2018

hotfix cast empty value as zero

@zonky2 zonky2 added the bug label Jun 8, 2018
@zonky2 zonky2 added this to the 2.0.4 milestone Jun 8, 2018
@zonky2 zonky2 requested a review from discordier June 8, 2018 15:45
@zonky2 zonky2 changed the title hotfix cast empty value as zero [RTM] hotfix cast empty value as zero Jun 16, 2018
@stefanheimes stefanheimes self-assigned this Jun 18, 2018
@stefanheimes
Copy link
Copy Markdown
Member

I don't know if i should merge this. Is only the symptom fix not the problem. Why did we get a empty value here. The attribute itself should greate this data and so we have a problem in the widgetToValue or in the loadData function. Did you have any information about this, where the empty value comes from?

If this is a problem with older database version of the attribute, we should add a update handler.
If we get all the time empty values, there must be another problem.
If we get this error only on some special events, we should handle it and fix it.

@stefanheimes
Copy link
Copy Markdown
Member

We should talk about this tomorrow.

@stefanheimes stefanheimes self-requested a review June 18, 2018 21:48
@stefanheimes stefanheimes merged commit 7601648 into master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants