Hotfix hide datepicker is widget readonly #21
Conversation
| $arrFieldDef = parent::getFieldDefinition($arrOverrides); | ||
| $arrFieldDef['eval']['rgxp'] = $strDateType; | ||
| $arrFieldDef['eval']['datepicker'] = ($strDateType !== 'time'); | ||
| $arrFieldDef['eval']['datepicker'] = !empty($arrFieldDef['eval']['readonly'])?false:true; |
There was a problem hiding this comment.
Please change this to $arrFieldDef['eval']['datepicker'] = empty($arrFieldDef['eval']['readonly']); as the result is already boolean.
Since when is time picker supported? Do we need to bump the minimum version in composer.json along the way?
There was a problem hiding this comment.
is this necessary?
...the attribute timestamp require "contao/core" and this require "contao-components/all" and this require "contao-components/datepicker"
There was a problem hiding this comment.
... o.k. separate PR
| $arrFieldDef['eval']['rgxp'] = $strDateType; | ||
| $arrFieldDef['eval']['datepicker'] = !empty($arrFieldDef['eval']['readonly'])?false:true; | ||
| $arrFieldDef['eval']['datepicker'] = empty($arrFieldDef['eval']['readonly']); | ||
| $arrFieldDef['eval']['tl_class'] .= ' wizard'; |
There was a problem hiding this comment.
Shouldn't this class only be added when there really is a wizard?
There was a problem hiding this comment.
I think, we should have this gap at readonly - so we have a chance to add a own diabled button icon per CSS... I don´t find this feature at datepicker plugin
There was a problem hiding this comment.
I fail to see the benefit of adding an icon which will never be clickable at all.
There was a problem hiding this comment.
I fail to see the benefit of adding an icon which will never be clickable at all.
it´s "contao standard" - the most icons habe a disabled status as "grey"
There was a problem hiding this comment.
Where do we have disabled wizards in Contao? O.o
There was a problem hiding this comment.
not disabled wizards, but icons with status "disabled"
|
@discordier with commit 8059400 should the label "Up for discussion" obsolete... and "we" can merge this... |
zonky2
force-pushed
the
Hotfix_hide_datepicker_at_readonly
branch
2 times, most recently
from
6925cc7 to
05ca89f
Compare
Squashed commit: [37e87aa] add css class 'wizard' [7cb826d] fix MetaModels#21 (review)
zonky2
force-pushed
the
Hotfix_hide_datepicker_at_readonly
branch
from
05ca89f to
bfda4ee
Compare
Squashed commit: [37e87aa] add css class 'wizard' [7cb826d] fix MetaModels#21 (review) (+1 squashed commits) Squashed commits: [251a525] Hotfix hide datepicker is widget readonly
zonky2
force-pushed
the
Hotfix_hide_datepicker_at_readonly
branch
from
bfda4ee to
3aaceb6
Compare
|
? |
|
without this its not possible to save a input mask with readonly timestamp |
| $arrFieldDef = parent::getFieldDefinition($arrOverrides); | ||
| $arrFieldDef['eval']['rgxp'] = $strDateType; | ||
|
|
||
| if (!empty($arrFieldDef['eval']['readonly'])) { |
There was a problem hiding this comment.
false condition :-(
- if (!empty($arrFieldDef['eval']['readonly'])) {
+ if (empty($arrFieldDef['eval']['readonly'])) {
|
Eh, YOU told me it is ok to merge. |
|
nobody is perfect :-( |
|
Ok, we will fix. Need a unit test then. ;) |
2 participants
Hotfix hide datepicker is widget readonly and activate picker also for time