[RTM] Fix warnings in the picker widget.#1256
Merged
discordier merged 2 commits intohotfix/2.0.7from Dec 17, 2018
Merged
Conversation
baumannsven
approved these changes
Dec 14, 2018
zonky2
changed the title
discordier
added a commit
that referenced
this pull request
Dec 17, 2018
This calls `Controller::setStaticUrls()` for pickers to have the constants available.
discordier
added a commit
that referenced
this pull request
Dec 19, 2018
Maintenance release. Fixes: - #1256 - Fix warning of undefined constants TL_ASSETS_URL and TL_FILES_URL. - #1257 - Hide sorting hint in popup widgets. - #1258, #1234 Frontend filter widgets for simple lookup can now be enabled and disabled via a checkbox. - #1259 - Changed the default behavior of the `getFilterOptions` to `usedOnly` if no id list is given.
discordier
added a commit
that referenced
this pull request
Dec 19, 2018
Maintenance release. Fixes: - #1256 - Fix warning of undefined constants TL_ASSETS_URL and TL_FILES_URL. - #1257 - Hide sorting hint in popup widgets. - #1258, #1234 Frontend filter widgets for simple lookup can now be enabled and disabled via a checkbox. - #1259 - Changed the default behavior of the `getFilterOptions` to `usedOnly` if no id list is given.
discordier
added a commit
that referenced
this pull request
Dec 19, 2018
Maintenance release. Fixes: - #1256 - Fix warning of undefined constants TL_ASSETS_URL and TL_FILES_URL. - #1257 - Hide sorting hint in popup widgets. - #1258, #1234 Frontend filter widgets for simple lookup can now be enabled and disabled via a checkbox. - #1259 - Changed the default behavior of the `getFilterOptions` to `usedOnly` if no id list is given. Conflicts: src/Attribute/BaseSimple.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The picker widget show warnings about missing constants TL_ASSETS_URL and TL_FILES_URL. This PR fixes it by calling
Controller::setStaticUrls()which defines the constants.Checklist
@authorsin touched PHP files