Closed
Conversation
discordier
requested changes
Mar 25, 2019
| // Try to parse the sub procedure and extract as much as possible. | ||
| if (($child['operation'] == 'AND') || ($child['operation'] == 'OR')) { | ||
| $subProcedure = new FilterBuilderSql($tableName, $child['operation'], $this->connection); | ||
| $subSkipped = $this->buildNativeSqlProcedure($subProcedure, $child['children']); |
Member
There was a problem hiding this comment.
Couldn't we just do
if (null === $child['children']) {
continue;
}here?
This would omit indenting everything here one level down.
Member
Author
There was a problem hiding this comment.
Sure! My fault. Ready for review.
richardhj
force-pushed
the
richardhj-patch-2
branch
from
f5820f5 to
29db8b5
Compare
Member
|
Author validation? 😸 |
richardhj
force-pushed
the
richardhj-patch-2
branch
from
29db8b5 to
ea32146
Compare
discordier
approved these changes
Mar 26, 2019
discordier
added a commit
that referenced
this pull request
Apr 3, 2019
Check if children exist in `FilterBuilder` for AND and OR filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://sentry.io/share/issue/ae6d1418cf194bbba3827eb5dc9d9690/ and https://sentry.io/share/issue/7687bab48f2f42fdaa5f69875f9f322d/)
Checklist
@authorsin touched PHP files