Throw an exception if item can not be found.#1295
Closed
richardhj wants to merge 2 commits intohotfix/2.1.1from
Closed
Throw an exception if item can not be found.#1295richardhj wants to merge 2 commits intohotfix/2.1.1from
richardhj wants to merge 2 commits intohotfix/2.1.1from
Conversation
richardhj
added
bug
discordier
added a commit
that referenced
this pull request
Apr 3, 2019
Throw a `RuntimeException` when a MetaModel item can not be found instead of running into a PHP error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception later gets catched and logged in the system log. The insert tag then will not become generated.
However, with the current version an error gets thrown, that will not be catched.
Fixes https://sentry.io/share/issue/81080c608c6d4d6b86464e2113dc6a00/.