Skip to content

Throw an exception if item can not be found. #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardhj wants to merge 2 commits into from
Closed

Throw an exception if item can not be found. #1295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6721fc8
Throw an exception if item can not be found.
richardhj Apr 1, 2019
5cb263f
Add throws definition.
richardhj Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/FrontendIntegration/InsertTags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* @author Stefan Heimes <stefan_heimes@hotmail.com>
* @author Sven Baumann <baumann.sv@gmail.com>
* @author David Molineus <david.molineus@netzmacht.de>
* @author Richard Henkenjohann <richardhenkenjohann@googlemail.com>
* @copyright 2012-2019 The MetaModels team.
* @license https://github.com/MetaModels/core/blob/master/LICENSE LGPL-3.0-or-later
* @filesource
Expand Down Expand Up @@ -256,12 +257,14 @@ protected function getItem($metaModelIdOrName, $mixDataId, $intIdRenderSetting,
* @param string $strOutput Name of output. Default:raw|text|html5|xhtml|...
*
* @return boolean|string Return false when nothing was found or return the value.
*
* @throws \RuntimeException If $intDataId does not provide an existingMetaModel ID.
*/
protected function getAttribute($metaModelIdOrName, $intDataId, $strAttributeName, $strOutput = 'raw')
{
// Get the MM.
$objMM = $this->loadMetaModel($metaModelIdOrName);
if ($objMM == null) {
if (null === $objMM) {
return false;
}

Expand All @@ -272,6 +275,9 @@ protected function getAttribute($metaModelIdOrName, $intDataId, $strAttributeNam

// Get item.
$objMetaModelItem = $objMM->findById($intDataId);
if (null === $objMetaModelItem) {
throw new \RuntimeException('MetaModel item not found: ' . $intDataId);
}

// Parse attribute.
$arrAttr = $objMetaModelItem->parseAttribute($strAttributeName);
Expand Down