Remove dependencies on legacy cca-extensions.#1314
Closed
richardhj wants to merge 2 commits intoMetaModels:masterfrom
Closed
Remove dependencies on legacy cca-extensions.#1314richardhj wants to merge 2 commits intoMetaModels:masterfrom
richardhj wants to merge 2 commits intoMetaModels:masterfrom
Conversation
zonky2
added
the
enhancement
Member
|
I'm not sure if this will break third party extensions but I also strongly doubt that anyone is still using these features... So I am undecided on this one. |
6 tasks
discordier
approved these changes
May 28, 2019
Member
discordier
left a comment
discordier
left a comment
There was a problem hiding this comment.
As discussed on mumble on 2019-05-28 we accept this PR for 2.2 as is.
Contributor
|
@richardhj can you push this at gitlab? base ist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I removed the dependency on the package
contao-community-alliance/dependency-containerbecause it requires
pimple/pimplein version 1.0. This conflicts with Deployer, which requires Pimple in version 3.Checklist
@authorsin touched PHP files