Closed
Conversation
discordier
requested changes
Oct 4, 2017
| if ($information['isSvgImage'] = $file->isSvgImage) { | ||
| $information['src'] = $fileName; | ||
| if (file_exists(TL_ROOT . '/' . $information['src'])) { | ||
| $size = getimagesize(TL_ROOT . '/' . $information['src']); |
Member
There was a problem hiding this comment.
Why are you fetching the size here and discard the value?
Does this really work with SVG?
If so, we should use the size value returned herin or (if specified) override it with the resize information.
Contributor
Author
There was a problem hiding this comment.
that´s right - I confused size with sizetext at template... I´ll kill this rows
zonky2
force-pushed
the
Hotfix_file_#58_add_SVG_support
branch
from
dc31c06 to
aa8563b
Compare
Contributor
Author
|
@discordier it´s now o.k.? |
discordier
approved these changes
Nov 30, 2017
Member
|
Merged with 26de141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix file #58 add SVG support