Skip to content

[RTM] hotfix strict mode at basesimple#1356

Merged
discordier merged 1 commit intomasterfrom
hotfix_strict_mode_at_basesimple
Dec 30, 2019
Merged

[RTM] hotfix strict mode at basesimple#1356
discordier merged 1 commit intomasterfrom
hotfix_strict_mode_at_basesimple

Conversation

@zonky2
Copy link
Copy Markdown
Contributor

@zonky2 zonky2 commented Dec 18, 2019

hotfix strict mode at basesimple
see issue #1335

@zonky2 zonky2 requested a review from discordier December 18, 2019 20:25
@zonky2 zonky2 added the bug A bug! A bug! Fast, squish it! label Dec 18, 2019
@zonky2 zonky2 added this to the 2.1.7 milestone Dec 18, 2019
@zonky2
Copy link
Copy Markdown
Contributor Author

zonky2 commented Dec 20, 2019

@discordier pls check this...

Copy link
Copy Markdown
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zonky2 confirmed that this still returns the correct results.

@zonky2 zonky2 changed the title hotfix strict mode at basesimple [RTM] hotfix strict mode at basesimple Dec 20, 2019
discordier added a commit that referenced this pull request Dec 30, 2019
This fixes a query error in `getFilterOptions()` when MySQL
is running in strict mode.
discordier added a commit that referenced this pull request Dec 30, 2019
Bugfix release

- Updated translations.
- updated the list of reserved keywords to be in sync with
  MySQL 8 (#1359).
- Changed the dependency from `TokenStorage` to
  `TokenStorageInterface` for building the backend
  navigation (#1354).
- Fixed some cosmetic issues in the support page (#1357).
- Fixed a query error in `getFilterOptions()` when MySQL
  is running in strict mode (#1356).
- Restored the ability to pass parameters as "get"
  parameter or from code (#1353).
@discordier discordier merged commit 6efcdf7 into master Dec 30, 2019
@discordier discordier deleted the hotfix_strict_mode_at_basesimple branch December 30, 2019 18:19
MacKP added a commit to MacKP/core-1 that referenced this pull request Mar 30, 2021
@MacKP MacKP mentioned this pull request Mar 30, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug! A bug! Fast, squish it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants