fix(eid-wallet): full-bleed app icon + light/dark/tinted iOS variants#1065
Open
Bekiboo wants to merge 1 commit into
Open
fix(eid-wallet): full-bleed app icon + light/dark/tinted iOS variants#1065Bekiboo wants to merge 1 commit into
Bekiboo wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (22)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes the iOS app icon: it's now full-bleed (purple to the edges) so iOS' corner mask no longer leaves a frame around it, and it ships explicit light/dark/tinted variants so iOS 18+ stops auto-darkening it. In dark mode the icon now stays purple with the white logo, as requested by the client.
Issue Number
Close #1063
Type of change
How the change has been tested
tauri ios dev.Change checklist
Design decisions
AppIcon.appiconsetto the single-size 1024 format with threeluminosityappearances (light / dark / tinted) instead of the legacy per-size layout. This is what lets us override iOS 18's auto-dark behaviour.tauri iconalso regenerated Android/desktop icons, but those were reverted: the bug is iOS-specific, and the full-bleed master overflows Android's adaptive-icon safe zone (logo would get clipped). Rolling the new design out to Android/desktop is a separate task.Re-running
tauri iconregenerates the legacy per-size layout and will overwrite these light/dark/tinted variants (same caveat flagged in #976). Re-apply the appearance catalog after any icon regeneration.