Skip to content

fix: blabsy modals#914

Merged
coodos merged 1 commit intomainfrom
fix/blabsy-modals
Mar 13, 2026
Merged

fix: blabsy modals#914
coodos merged 1 commit intomainfrom
fix/blabsy-modals

Conversation

@sosweetham
Copy link
Copy Markdown
Member

@sosweetham sosweetham commented Mar 13, 2026

Description of change

makes blabsy modals scrollable and height limited

Issue Number

n/a

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

n/a

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Style
    • Improved dialog layouts with max-height constraints and overflow-aware styling for group settings and member management interfaces.
    • Enabled vertical scrolling support within dialogs to ensure content remains accessible and properly contained within the viewport.

@sosweetham sosweetham requested a review from coodos as a code owner March 13, 2026 11:36
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4306f3d-134e-4249-9ab5-4415b9ac954b

📥 Commits

Reviewing files that changed from the base of the PR and between 93deeb5 and e4cb3a3.

📒 Files selected for processing (2)
  • platforms/blabsy/client/src/components/chat/group-settings.tsx
  • platforms/blabsy/client/src/components/chat/member-list.tsx

📝 Walkthrough

Walkthrough

This PR updates styling for two dialog components (group-settings and member-list) to implement flex-based layouts with constrained heights and internal scroll areas. Changes include adding max-height constraints, flex columns, and overflow-y-auto properties to enable vertical scrolling within panels.

Changes

Cohort / File(s) Summary
Dialog Panel Styling Updates
platforms/blabsy/client/src/components/chat/group-settings.tsx, platforms/blabsy/client/src/components/chat/member-list.tsx
Dialog.Panel and Dialog.Title classes updated to use flex containers with max-h-[90vh] and shrink-0 properties. Form/member container wrappers modified to include min-h-0, flex-1, and overflow-y-auto for scrollable content areas within fixed-height modals.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Fix/blabsy create message add scroll #808: Implements identical dialog panel styling updates (max-height flex containers and scrollable inner wrappers) across modal components, representing the same layout refactoring pattern.

Suggested reviewers

  • coodos

Poem

🐰 A panel grows tall with flex and restraint,
With scrolls that flow smooth, no vertical paint,
Two dialogs now dance in constrained grace,
Max-height and min-h guide each component's place! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix: blabsy modals' is vague and lacks specific detail about what aspect of the modals is being fixed, making it difficult for teammates to understand the primary change from the title alone. Consider revising the title to be more specific, such as 'fix: make blabsy modals scrollable and height-limited' to clearly convey the nature of the fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description follows the required template structure and includes all necessary sections with appropriate information for the change type.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/blabsy-modals
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coodos coodos merged commit 6162859 into main Mar 13, 2026
4 checks passed
@coodos coodos deleted the fix/blabsy-modals branch March 13, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants