Skip to content

Fix/max retries deadletter queue#963

Merged
coodos merged 2 commits into
mainfrom
fix/max-retries-deadletter-queue
May 17, 2026
Merged

Fix/max retries deadletter queue#963
coodos merged 2 commits into
mainfrom
fix/max-retries-deadletter-queue

Conversation

@coodos
Copy link
Copy Markdown
Contributor

@coodos coodos commented May 17, 2026

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Warning

Rate limit exceeded

@coodos has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 67b8bceb-1645-4200-b891-c029f7ff51e8

📥 Commits

Reviewing files that changed from the base of the PR and between 17f7aed and f3f6f6f.

📒 Files selected for processing (6)
  • .env.example
  • docs/docs/Services/Awareness-as-a-Service.md
  • services/awareness-service/api/src/config.ts
  • services/awareness-service/api/src/database/entities/Delivery.ts
  • services/awareness-service/api/src/openapi.ts
  • services/awareness-service/api/src/services/DeliveryEngine.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/max-retries-deadletter-queue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coodos coodos marked this pull request as ready for review May 17, 2026 19:45
@coodos coodos merged commit 7069493 into main May 17, 2026
3 of 4 checks passed
coodos added 2 commits May 18, 2026 18:00
Lower the default AWARENESS_MAX_ATTEMPTS from 8 to 3.
A dead-lettered delivery was left with status 'failed', which claimBatch
selects - so the engine re-claimed it every tick, re-attempted it, inflated
its attempt count without bound and inserted a fresh dead-letter row each
time. Mark exhausted deliveries with a terminal 'dead' status and exclude any
delivery at/over the attempt cap from claiming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant