comments: correct permissions for showing the edit option #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlbmtc
requested changes
Oct 30, 2024
draaglom
added a commit
to draaglom/metaculus
that referenced
this pull request
Oct 30, 2024
draaglom
force-pushed
the
draaglom/fix-comment-edit-menu
branch
2 times, most recently
from
c08686a to
81d2b80
Compare
until now, we were incorrectly showing 'edit' in the dropdown menu on other people's comments when they were a reply to your comment. this was because: - we passed down a single permissions object recursively which represented the amalgam of 'you can edit because you run the project' and alseo 'you can edit because this was your comment' - we set that permission to an edit-allowing one any time a comment you create is found in the tree and never unset it (and indeed we couldn't unset it, without also having the context re: post/project permissions) instead, we now let each comment determine its own editability directly. Note that: 1. this adds the edit option to comments on your profile comment feed, which is a slight change of behaviour. I started to remove that again but then thought maybe it's desirable to keep? so thought I'd ask first 2. I don't quite know enough of my way around to properly test the curator/admin side yet, but I've tested and the user side works (and the code itself is pretty straightforward) resolves Metaculus#1160
draaglom
force-pushed
the
draaglom/fix-comment-edit-menu
branch
from
81d2b80 to
4efa369
Compare
draaglom
commented
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until now, we were incorrectly showing 'edit' in the dropdown menu on other people's comments when they were a reply to your comment.
this was because:
instead, we now let each comment determine its own editability directly.
Note that I don't quite know enough of my way around to properly test the curator/admin side yet, but I've tested and the user side works (and the code itself is pretty straightforward)
resolves #1160