Skip to content

Show number of forecasters when displaying a single group subquestion #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ncarazon merged 1 commit into from
Nov 13, 2024
Merged

Show number of forecasters when displaying a single group subquestion #1393

ncarazon merged 1 commit into from
Nov 13, 2024

Conversation

@ncarazon
Copy link
Contributor

@ncarazon ncarazon commented Nov 13, 2024

  • refactored the logic to manage group question charts for multi-option variant as a single component to reduce repetitive code and simplify further component updates.
  • implemented a logic to calculate forecasters count based on highlight (hover) state and active state for group options.
  • implemented a logic to calculate forecasters count based on highlight (hover) state and active state for multiple-choice questions.
  • integrated forecasts counter into chart UI.
  • bonus: fixed empty labels on timeline chart for conditional questions (regression after integrating BE-driven label field).

@ncarazon ncarazon merged commit 8b94f84 into main Nov 13, 2024
2 checks passed
@ncarazon ncarazon deleted the feat/show-number-of-forecasters-when-displaying-a-single-group branch November 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ncarazon