Skip to content

TheCurve QA Feedback v3 #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

TheCurve QA Feedback v3 #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion front_end/src/app/(main)/questions/[id]/components/forecast_maker/binary_slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type Props = {
helperDisplay?: boolean;
className?: string;
styles?: Partial<Record<SemanticName, CSSProperties>>;
withArrowStep?: boolean;
};

const BinarySlider: FC<Props> = ({
Expand All @@ -35,6 +36,7 @@ const BinarySlider: FC<Props> = ({
helperDisplay = false,
className,
styles,
withArrowStep = true,
}) => {
const inputDisplayValue = forecast ? forecast.toString() + "%" : "—";
const [, setInputValue] = useState(inputDisplayValue);
Expand Down Expand Up @@ -87,7 +89,7 @@ const BinarySlider: FC<Props> = ({
defaultValue={forecast ?? DEFAULT_SLIDER_VALUE}
onChange={handleSliderForecastChange}
step={1}
arrowStep={0.1}
arrowStep={withArrowStep ? 0.1 : undefined}
shouldSyncWithDefault
marks={
communityForecast
Expand Down
20 changes: 10 additions & 10 deletions front_end/src/app/(thecurve)/components/curve_histogram/curve_histogram.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@ const CurveHistogram: FC<Props> = ({
padding={{ top: 0, bottom: 25, left: 10, right: 10 }}
height={height}
>
<VictoryBar
data={histogramData}
style={{
data: {
fill: "light" + color,
},
}}
barRatio={1.7}
x={(d) => d.x + 0.5}
/>
<VictoryAxis
tickValues={range(0, 101)}
tickFormat={(x: number) => (x % 10 === 0 ? `${x}%` : "")}
Expand All @@ -65,16 +75,6 @@ const CurveHistogram: FC<Props> = ({
grid: { stroke: "none" },
}}
/>
<VictoryBar
data={histogramData}
style={{
data: {
fill: "light" + color,
},
}}
barRatio={1.7}
x={(d) => d.x + 0.5}
/>
{choiceOptions[0].forecast && (
<VictoryScatter
data={[{ y: 0, x: choiceOptions[0].forecast * 100 }]}
Expand Down
1 change: 1 addition & 0 deletions front_end/src/app/(thecurve)/components/forecast_maker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ const CurveForecastMaker: FC<Props> = ({
rail: { backgroundColor: "white", height: "3px" },
track: { backgroundColor: "white", height: "3px" },
}}
withArrowStep={false}
/>
</React.Fragment>
))}
Expand Down