Fix sub-menu text color and jumping #364

Aprillion · 2024-09-01T16:55:49Z

fix "More" menu has a dark background in light mode. #325 by using the same text color in sub-menu as in the main menu (the issue implies to change background, but this looked more consistent IMHO)
also fix the jumping menu (now there is empty background behind the removed scroll bar when headlessui adds the overflow: hidden inline style to <html> element while sub-menu is open) * only reproducible when using visible scrollbars - mostly on Windows, but there is a setting for it on Mac too..
- no idea if the fix to work correctly in Safari (but I don't expect any Safari user would enable always visible scroll bars in the first place, so hopefully not a high priority that would prevent merging this PR ... if it's broken in Safari, it should be equally broken before and after adding scrollbar-gutter:stable)

George3d6 · 2024-09-02T15:41:09Z

Looks great, thank you :)

Aprillion added 3 commits September 1, 2024 16:00

fix text color in light mode (Metaculus#325)

b4987dd

fix jumping menu

c7cf6fc

npm run format

3fdae4e

Aprillion mentioned this pull request Sep 1, 2024

GitHub Codespaces support #363

Open

Aprillion temporarily deployed to testing_env September 2, 2024 15:41 — with GitHub Actions Inactive

Aprillion had a problem deploying to testing_env September 2, 2024 15:41 — with GitHub Actions Failure

George3d6 merged commit b7eb50d into Metaculus:main Sep 2, 2024

Provide feedback