Child question group links backward compatibility #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckward-compatibility' into feat/662-question-group-links-backward-compatibility
hlbmtc
deleted the
feat/662-question-group-links-backward-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backward compatibility workaround. Initially, all group question links were generated as
/questions/<child_question_id>, which redirected to/questions/<post_id>/?sub-question=<child_question_id>. Now that posts and questions are differentiated, these redirects are no longer supported.This workaround tracks the last known legacy question ID. If a 404 lookup contains an ID lower than the last legacy question ID, we assume it may refer to a child question in a group. If so, we attempt to replace its ID with the original post_id when possible.
This works because our post ids were migrated from question ids and these 2 models do not have ids collision upon the release date, that's why we need
LAST_LEGACY_QUESTION_IDcloses #662