Skip to content

Don't add -i to docker command when stdin is not a TTY #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxdymond merged 1 commit into from
Apr 18, 2023
Merged

Don't add -i to docker command when stdin is not a TTY #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Status: Available for use
### Added

### Fixed
- Don't add "-i" to docker commands when stdin is not a tty. This allows commands `floki run -- <command>` to be run from inside other scripts even if stdout looks like a tty.

## [1.0.0] - 2022-09-12

Expand Down
2 changes: 1 addition & 1 deletion src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ impl DockerCommandBuilder {

fn base_args(&self) -> Vec<&OsStr> {
let mut base_args: Vec<&OsStr> = vec!["run".as_ref(), "--rm".as_ref(), "-t".as_ref()];
if atty::is(atty::Stream::Stdout) {
if atty::is(atty::Stream::Stdout) && atty::is(atty::Stream::Stdin) {
base_args.push("-i".as_ref());
}
base_args
Expand Down