Add FLOKI_WORKING_DIR environment variable#439
Merged
Conversation
added 2 commits
September 25, 2024 13:59
- Add `FLOKI_WORKING_DIR` environment variable that is accessible inside the container. Can be used when `mount:` has been specified in `floki.yaml`. Signed-off-by: Max Dymond <max.dymond@microsoft.com>
Signed-off-by: Max Dymond <max.dymond@microsoft.com>
Member
Author
|
Reviewed internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLOKI_WORKING_DIRenvironment variable that is accessible inside the container. Can be used whenmount:has been specified infloki.yaml.Why this change?
If someone specifies
mount:then the assumption that code is mounted at /src is wrong.Relevant testing
Local testing
Contributor notes
N/A
Checks
These aren't hard requirements, just guidelines
cargo fmtREADME.mdupdated for this change, if necessaryCHANGELOG.mdupdated for this change