Conversation
ShaWritter file and Write file copied from rpmoci. Could definitely make my own writer but it was there so I used it.
use ocidir, simplify cli ---- #### AI description (iteration 1) #### PR Classification Code cleanup and CLI simplification. #### PR Summary This pull request refactors the code to use the `ocidir` crate and simplifies the CLI implementation. - Removed `helm_to_oci/src/lib.rs` and its associated functionality. - Added new CLI implementation in `src/main.rs` using `argh` for argument parsing. - Updated dependencies in `Cargo.lock` to reflect the new crate usage and removed unused dependencies. Related work items: #1741777
tofay
reviewed
Sep 3, 2024
| check: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: mcr.microsoft.com/cbl-mariner/base/core:2.0 |
| runs-on: ubuntu-latest | ||
| container: | ||
| image: mcr.microsoft.com/cbl-mariner/base/core:2.0 | ||
| options: --privileged |
Collaborator
There was a problem hiding this comment.
why privileged? (but again suggest just running in ubuntu 24.04)
| with: | ||
| toolchain: stable | ||
| override: true | ||
| - uses: katyo/publish-crates@v2 |
Collaborator
There was a problem hiding this comment.
do we use this elsewhere? how widely used in msft is it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR moving code to open source github repository