This repository was archived by the owner on Apr 22, 2020. It is now read-only.
Fix the case where Brotli doesn't consume all input. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JNI wrapper in C++ currently assumes that Brotli consumes all of the available bytes in the input buffer, but this isn't always the case. Brotli will sometimes leave the
in_availablevalue less than the number of bytes available, which causes jbrotli to discard some unprocessed input bytes and fail decompression.This patch adds
BrotliStreamDeCompressorResultto return the error code, bytes consumed, and bytes produced by the stream decompressor and correctly updates the ByteBuffer handling in Java to correctly track what of the input buffer was consumed (so it can be passed into Brotli again to consume the rest). Using a Java class also avoids packing and unpacking the return value.