Skip to content

DT-196 Integrate GitOps pipeline#65

Merged
nestabur merged 5 commits intomainfrom
feature/DT-196-integrate-gitops-pipeline
Jan 29, 2025
Merged

DT-196 Integrate GitOps pipeline#65
nestabur merged 5 commits intomainfrom
feature/DT-196-integrate-gitops-pipeline

Conversation

@nestabur
Copy link
Copy Markdown
Contributor

No description provided.

@nestabur nestabur self-assigned this Jan 23, 2025
Copy link
Copy Markdown
Contributor

@mkretz mkretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nestabur! One comment / question.

Comment thread Jenkinsfile
Comment thread Jenkinsfile
Comment thread Jenkinsfile
Comment thread Jenkinsfile
Comment thread .mch-ci.yml Outdated
Comment thread .mch-ci.yml Outdated
@nestabur nestabur requested review from mkretz and petermkr January 29, 2025 09:10
@petermkr
Copy link
Copy Markdown
Collaborator

One last comment from my side:
You could consider removing the version from pyproject.toml and setting the package mode.

@nestabur
Copy link
Copy Markdown
Contributor Author

One last comment from my side: You could consider removing the version from pyproject.toml and setting the package mode.

Thanks for the comment! Since pyflexplot is also installed as a library (at CSCS) we cannot remove it. We need to check whether is installed via our PyPI repo, or if is built from the sources. In both cases the version is required. We might need to include the publishing of the python package if it is installed from our package repo (and we are missing the functionality of having on sync the TAG and the version in pyproject.toml at the moment)

@petermkr
Copy link
Copy Markdown
Collaborator

One last comment from my side: You could consider removing the version from pyproject.toml and setting the package mode.

Thanks for the comment! Since pyflexplot is also installed as a library (at CSCS) we cannot remove it. We need to check whether is installed via our PyPI repo, or if is built from the sources. In both cases the version is required. We might need to include the publishing of the python package if it is installed from our package repo (and we are missing the functionality of having on sync the TAG and the version in pyproject.toml at the moment)

Thanks for elaborating. Then all is good from my side.

@nestabur nestabur merged commit f7a8902 into main Jan 29, 2025
@nestabur nestabur deleted the feature/DT-196-integrate-gitops-pipeline branch January 29, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants