Fix: read baselines from grib instead of zarr for meteograms#164
Merged
Conversation
Contributor
Author
|
I am now trying this out to make sure it works. If it does, could you @cosunae please add it to your PR (or we merge in sequence, once unify... is merged). |
Contributor
Author
|
ok, this is now ready. Works with the interpolators-ich1.yaml config when enabling meteograms as well. |
jonasbhend
changed the title
Contributor
|
Let's merge this! Thanks a lot @jonasbhend |
jonasbhend
force-pushed
the
fix_for_meteogram
branch
from
ac2a42c to
c4843f9
Compare
jonasbhend
force-pushed
the
fix_for_meteogram
branch
from
c4843f9 to
0b610e1
Compare
cosunae
reviewed
May 28, 2026
| ds = ds.drop_vars(["U_10M", "V_10M"]) | ||
| if param == "SP": | ||
| ds[param] = ekm_wind.speed(ds.U, ds.V) | ||
| ds[param] = (ds.U**2 + ds.V**2) ** 0.5 |
Contributor
There was a problem hiding this comment.
the use of ekm was implemented as part of a review, is it not working?
Contributor
Author
There was a problem hiding this comment.
no it is not working because earthkit wants a numpy array, but we are giving it a xarray DataArray. we could probably just change this to ekm_wind.speed(ds.U.values, ds.V.values) and then it should work. Should I revert that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes