Skip to content

Retain sample size for further aggregation of strata#168

Merged
jonasbhend merged 1 commit into
mainfrom
feat/correct_aggregates
Jun 2, 2026
Merged

Retain sample size for further aggregation of strata#168
jonasbhend merged 1 commit into
mainfrom
feat/correct_aggregates

Conversation

@jonasbhend
Copy link
Copy Markdown
Contributor

@jonasbhend jonasbhend commented Jun 2, 2026

Summary of changes

  • retain a counter of samples for the different init_hour and season strata for further aggregation
  • fix a bug in scaling of seasonal and per init_hour counts for the contingency table

@jonasbhend jonasbhend marked this pull request as ready for review June 2, 2026 06:31
@jonasbhend jonasbhend requested a review from dnerini June 2, 2026 06:34
Copy link
Copy Markdown
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, looking good to me!

@jonasbhend jonasbhend merged commit 7c119a1 into main Jun 2, 2026
4 of 5 checks passed
@dnerini dnerini deleted the feat/correct_aggregates branch June 2, 2026 09:32
jonasbhend added a commit that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants