use uuids for lookup and update usernames #5728
Merged
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I don't see the point in making this a config option, just make it default to searching by id and fall back to the name if the id is null |
Contributor
Author
removed config option as requested |
2 tasks
MukjepScarlet
pushed a commit
to MukjepScarlet/meteor-client
that referenced
this pull request
Oct 7, 2025
…t#5728) Should make the friends system more consistent and alleviate issues caused by mojang rate limiting one of their api endpoints. Updating the friends list may cause a small lag spike on startup depending on how many friends you have (the only reason this didn't happen before is because of the aformentioned rate limiting issues). Co-authored-by: Wide_Cat <widecat@duck.com>
chri-k
pushed a commit
to chri-k/meteor-client
that referenced
this pull request
Nov 15, 2025
…t#5728) Should make the friends system more consistent and alleviate issues caused by mojang rate limiting one of their api endpoints. Updating the friends list may cause a small lag spike on startup depending on how many friends you have (the only reason this didn't happen before is because of the aformentioned rate limiting issues). Co-authored-by: Wide_Cat <widecat@duck.com> (cherry picked from commit ff7373a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Uses UUIDs instead of usernames for friends info update/lookup
Configuration to keep username lookup kept for offline mode environments
Related issues
#5687
How Has This Been Tested?
https://youtu.be/gQRDZIzlGQs
Checklist: