chore: bump anchor v1#51
Merged
Merged
Conversation
Contributor
Author
|
/bot review |
|
Bot Agent progress:
Progress:
|
There was a problem hiding this comment.
Verdict
Request changes
Summary
Posted 2 validated inline finding(s) after final filtering.
Findings
- [P1]
Cargo.toml:15With this Anchor v1 bump,cargo clippy --workspace --all-targets -- -D warningsnow fails:declare_program!(jupiter)inlibs/jupiter/src/lib.rs:3triggersclippy::too_many_argumentsfrom the generated code. Please add a targeted allow around that macro/crate, or otherwise make clippy pass, before merging. - [P3]
README.md:32bun run testno longer builds the program/IDL, while the tests load files fromtarget/idl/target/deployandtargetis gitignored. On a clean checkout this command will fail unlessbun run build-localran first; consider documentingbun run build-local-testhere or adding the build step back totest.
Repo checks
Repo Checks
- rustup component add --toolchain 1.93.0-x86_64-unknown-linux-gnu rustfmt: ok
info: component rustfmt is up to date
- rustup component add --toolchain 1.93.0-x86_64-unknown-linux-gnu clippy: ok
info: component clippy is up to date
- cargo fetch --locked: ok
Updating git repository `https://github.com/MeteoraAg/damm-v2`
From https://github.com/MeteoraAg/damm-v2
* [new ref] c918cb8023dc01cb01a84c322bb94128cd0abfc8 -> refs/commit/c918cb8023dc01cb01a84c322bb94128cd0abfc8
- cargo check --workspace: ok
stem-interface v2.0.0
Checking solana-last-restart-slot v3.0.0
Checking solana-slot-hashes v3.0.1
Checking solana-slot-history v3.0.0
Checking solana-epoch-schedule v3.1.0
Checking solana-instructions-sysvar v3.0.0
Checking solana-clock v3.0.1
Checking solana-epoch-rewards v3.0.1
Checking solana-rent v3.1.0
Checking solana-zk-sdk v4.0.0
Checking solana-cpi v3.1.0
Checking solana-stable-layout v3.0.1
Checking solana-system-interface v3.2.0
Checking spl-type-length-value v0.9.1
Checking solana-sysvar v3.1.1
Checking spl-token-group-interface v0.7.2
Checking solana-invoke v0.5.0
Checking spl-token-interface v2.0.0
Checking spl-associated-token-account-interface v2.0.0
Checking solana-stake-interface v2.0.2
Checking solana-loader-v3-interface v6.1.1
Checking spl-pod v0.7.3
Checking spl-token-confidential-transfer-proof-generation v0.5.1
Checking spl-token-metadata-interface v0.8.0
Checking spl-token-confidential-transfer-proof-extraction v0.5.1
Compiling anchor-derive-serde v1.0.1
Compiling anchor-attribute-program v1.0.1
Compiling anchor-attribute-event v1.0.1
Compiling anchor-attribute-error v1.0.1
Compiling anchor-derive-accounts v1.0.1
Compiling anchor-attribute-account v1.0.1
Compiling anchor-attribute-constant v1.0.1
Checking spl-token-2022-interface v2.1.0
Checking anchor-lang v1.0.1
Checking jupiter v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/libs/jupiter)
Checking anchor-spl v1.0.1
Checking dlmm v0.10.1 (/data/workdir/2962945/MeteoraAg/zap-program/libs/dlmm)
Checking protocol-zap v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/protocol-zap)
Checking cp-amm v0.2.1 (https://github.com/MeteoraAg/damm-v2?rev=c918cb8023dc01cb01a84c322bb94128cd0abfc8#c918cb80)
Checking zap v0.2.2 (/data/workdir/2962945/MeteoraAg/zap-program/programs/zap)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.04s
- cargo fmt --check: ok
- cargo clippy --workspace --all-targets -- -D warnings: failed
Checking jupiter v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/libs/jupiter)
Checking zap-sdk v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/zap-sdk)
Checking dlmm v0.10.1 (/data/workdir/2962945/MeteoraAg/zap-program/libs/dlmm)
error: this function has too many arguments (8/7)
--> libs/jupiter/src/lib.rs:3:1
|
3 | declare_program!(jupiter);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
= note: this error originates in the macro `declare_program` (in Nightly builds, run with -Z macro-backtrace for more info)
error: this function has too many arguments (8/7)
--> libs/jupiter/src/lib.rs:3:1
|
3 | declare_program!(jupiter);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments
= note: this error originates in the macro `declare_program` (in Nightly builds, run with -Z macro-backtrace for more info)
error: could not compile `jupiter` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `jupiter` (lib test) due to 2 previous errors
bangyro
reviewed
May 4, 2026
bangyro
approved these changes
May 5, 2026
bangyro
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bunas package manager + runtime for test instead of combined package manager such aspnpm+yarn.bunis more memory efficientTODO
anchor idl inithttps://github.com/solana-foundation/anchor/blob/7b108db7987afedd1e72edd783d7fc00416e213f/docs/content/docs/updates/release-notes/1-0-0.mdx#legacy-idl-instructions-replaced-by-program-metadata
Program metadata: https://github.com/solana-program/program-metadata