Skip to content

Add Windows OS build and deployment#5

Merged
jody merged 9 commits into
MetroCS:mainfrom
jody:main
Dec 25, 2025
Merged

Add Windows OS build and deployment#5
jody merged 9 commits into
MetroCS:mainfrom
jody:main

Conversation

@jody
Copy link
Copy Markdown
Contributor

@jody jody commented Dec 25, 2025

Add build and packaging into the Ant and GitHub build processes.
Side-effect: Refactor build.xml handling of javadoc task to allow for parameterized generation.

jody and others added 6 commits December 25, 2025 14:39
Updated formatting and clarified instructions in README.
Co-authored-by: jody <379845+jody@users.noreply.github.com>
Update the ant build script (build.xml) and the GitHub build action (.github/workflows/build.yaml).
Construct and add appropriate Windows icon file (icon.ico).
Add explanation and instructions to readme file (README.md).
One target now reflects the general usage api.
The other target shows all members, including protected and private.
…ags.

Hid the constructor to indicate Main is a utility class.
@jody jody requested a review from Copilot December 25, 2025 22:48
@jody jody added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 25, 2025
@jody jody self-assigned this Dec 25, 2025
Comment thread src/Main.java
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Windows support to the native application build and deployment process, enabling the creation of MSI installers alongside existing macOS DMG and Linux DEB packages. Additionally, it refactors the Ant build script's javadoc generation to use a parameterized macro, allowing both standard API documentation and internal documentation (including private members) to be generated.

Key changes:

  • Adds Windows MSI installer build target with WiX Toolset integration
  • Refactors javadoc generation into a reusable macrodef with configurable access levels
  • Updates documentation with Windows-specific setup instructions and requirements
  • Adds Windows runner to GitHub Actions CI/CD pipeline

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
src/Main.java Adds version tag, author tag, and private constructor following utility class pattern
build.xml Introduces javadoc macrodef for parameterized documentation generation; adds Windows OS detection, icon.ico support, and windows target for MSI creation; adds javadoc-internal and javadoc-all targets
README.md Expands documentation with Windows setup instructions, WiX Toolset requirements, icon.ico asset details, and updates all platform references to include Windows
.github/workflows/build.yaml Adds windows-latest to OS matrix and includes .msi artifacts in release assets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Main.java Outdated
Comment thread src/Main.java Outdated
Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor Author

@jody jody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #3
Closes #4

jody and others added 3 commits December 25, 2025 15:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a second ant target with more detailed javadoc output Add build and packaging support for Windows OS

3 participants