Skip to content
This repository was archived by the owner on Feb 2, 2026. It is now read-only.

Create generic_summary module#23

Merged
bpepple merged 3 commits intomasterfrom
refactor-summary
Oct 28, 2021
Merged

Create generic_summary module#23
bpepple merged 3 commits intomasterfrom
refactor-summary

Conversation

@bpepple
Copy link
Copy Markdown
Member

@bpepple bpepple commented Oct 28, 2021

Let's remove a bunch of duplicate code

Let's remove a bunch of duplicat code
@bpepple bpepple self-assigned this Oct 28, 2021
@bpepple bpepple added the chore Miscellaneous drudgery label Oct 28, 2021
@bpepple bpepple linked an issue Oct 28, 2021 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #23 (224dd10) into master (4f24c43) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   95.97%   95.65%   -0.32%     
==========================================
  Files          28       23       -5     
  Lines        1365     1267      -98     
==========================================
- Hits         1310     1212      -98     
  Misses         55       55              
Flag Coverage Δ
unittests 95.65% <100.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
esak/character.py 87.09% <100.00%> (ø)
esak/comic.py 93.90% <100.00%> (ø)
esak/creator.py 88.88% <100.00%> (ø)
esak/event.py 92.53% <100.00%> (ø)
esak/generic_summary.py 100.00% <100.00%> (ø)
esak/series.py 92.95% <100.00%> (ø)
esak/stories.py 87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f24c43...224dd10. Read the comment docs.

@bpepple bpepple marked this pull request as ready for review October 28, 2021 03:58
@bpepple bpepple merged commit fd35f5b into master Oct 28, 2021
@bpepple bpepple deleted the refactor-summary branch October 28, 2021 03:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Miscellaneous drudgery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor individual summary modules into a generic summary module

2 participants