Remove pump adiabatic compression #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes #288 by removing the adiabatic compression (no retrocompatibity issue as this parameter was not used, and not present in the
_withStartValuesmodel)Also fixes #302 by giving physically sound values for the unit test.
Type of change
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.
GitHub checks:
Model development checks:
Library checks:
Documentation checks: