NEW EXAMPLE - MetroscopiaCCGT_faulty #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadrienp-met
added
👨💻 Example
hadrienp-met
requested review from
helenev-met,
nabily-met,
pierre-eliep-met and
valentind-met
Contributor
valentind-met
left a comment
valentind-met
left a comment
There was a problem hiding this comment.
Ok for the added model. But I thought you had to modify the direct and reverse models because of the new psiA and psiG units?
Are you sure the examples all run correctly in your branch?
Contributor
Author
Actually my repertory was not up to date and this problem was solved with a previous PR #281 |
Contributor
|
Ok, perfect! |
valentind-met
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Faulty model added to MetroscopiaCCGT
Type of change