Skip to content

Conversation

@nabily-met
Copy link
Contributor

@nabily-met nabily-met commented Mar 3, 2023

Goal

Replaced Q^2 by Q*abs(Q) in the Pipe component to have a unique flow direction according the pressure difference we have on the pipe.

Closes #384

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass.
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

Signed-off-by: Nabil YOUSSEF <nabil.youssef@metroscope.tech>
@nabily-met nabily-met added the 🐛bug Something isn't working label Mar 3, 2023
@nabily-met nabily-met self-assigned this Mar 3, 2023
@nabily-met nabily-met merged commit b5d499c into main Mar 3, 2023
@nabily-met nabily-met deleted the NY_PipeFlowSign branch March 3, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Flow direction in a pipe

3 participants