Skip to content

deleted compressor power inlet in gas turbine #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2023
Merged

deleted compressor power inlet in gas turbine #410

merged 3 commits into from
Apr 7, 2023

Conversation

@valentind-met
Copy link
Contributor

@valentind-met valentind-met commented Apr 7, 2023 •
edited
Loading

Goal

Fix #409 and fix #342

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass.
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@valentind-met valentind-met added this to the v3.5.0 milestone Apr 7, 2023
@valentind-met valentind-met added the ♻️refactoring A code change that neither fixes a bug nor adds a feature label Apr 7, 2023
@valentind-met valentind-met self-assigned this Apr 7, 2023
@valentind-met valentind-met requested a review from nabily-met April 7, 2023 08:44
nabily-met
nabily-met reviewed Apr 7, 2023
View reviewed changes
MetroscopeModelingLibrary/FlueGases/Machines/GasTurbine.mo Outdated
tau = P_in/P_out;

/* Fluid specific enthalpy after the expansion */
h_out-h_in = eta_is*(h_is-h_in);
Copy link
Contributor

@nabily-met nabily-met Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces between signs: h_out - h_in = eta_is*(h_is - h_in);

nabily-met
nabily-met reviewed Apr 7, 2023
View reviewed changes
MetroscopeModelingLibrary/FlueGases/Machines/GasTurbine.mo Outdated
Wmech = - C_W_out.W;
Wcompressor = - C_W_compressor.W;
Wmech = eta_mech*Q*(h_in - h_out) - Wcompressor;
W_shaft =-C_W_shaft.W;
Copy link
Contributor

@nabily-met nabily-met Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@valentind-met valentind-met merged commit 40e9f93 into main Apr 7, 2023
@valentind-met valentind-met deleted the GT_refacto branch April 7, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nabily-met nabily-met nabily-met approved these changes

Assignees

@valentind-met valentind-met

Labels

♻️refactoring A code change that neither fixes a bug nor adds a feature

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

[FEATURE] Remove the W compressor connector in the Gas turbine [FEATURE] GasTurbine power and mechanical efficiency renaming

3 participants

@valentind-met @nabily-met