Skip to content

Conversation

@teodorionita
Copy link
Contributor

@teodorionita teodorionita commented Oct 22, 2025

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 9 to +10
# Command to run - can be overridden for different scripts
command: ["uv", "run", "python", "-m", "softmax.dashboard.report", "report", "--push"]
command: ["uv", "run", "python", "-m", "softmax.dashboard.report", "--push"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Cronjob no longer invokes Typer command

The CLI in softmax.dashboard.report registers report as the only subcommand (@app.command() in softmax/src/softmax/dashboard/report.py). By dropping the literal "report" here, the CronJob now runs uv run python -m softmax.dashboard.report --push, which Typer treats as a missing command and fails with No such option --push. This means the scheduled job will exit before collecting or pushing metrics, so the dashboard will never update.

Useful? React with 👍 / 👎.

@teodorionita teodorionita added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 31d5f25 Oct 22, 2025
32 of 35 checks passed
@teodorionita teodorionita deleted the teodorionita-fix-report-command branch October 22, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants