Skip to content

Conversation

@sasmith
Copy link
Contributor

@sasmith sasmith commented Nov 19, 2025

Copy link
Contributor Author

sasmith commented Nov 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sasmith sasmith requested a review from relh November 19, 2025 22:29
@sasmith sasmith marked this pull request as ready for review November 19, 2025 22:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +709 to +713
package_root = Path(__file__).parent.parent.parent
docs_map: dict[str, tuple[Path, str]] = {
"readme": (package_root / "README.md", "CoGames overview and documentation"),
"mission": (package_root / "MISSION.md", "Mission briefing for Machina VII Deployment"),
"technical_manual": (package_root / "TECHNICAL_MANUAL.md", "Technical manual for Cogames"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve docs command paths inside the installed package

The new docs command builds package_root = Path(__file__).parent.parent.parent and then points all documents to package_root / "README.md", MISSION.md, etc. In an installed wheel, __file__ lives at <venv>/site-packages/cogames/main.py, so this path climbs out of the package to the Python install root (e.g., /usr/local/lib/python3.12/README.md), tripping the subsequent exists() check and causing every cogames docs <name> invocation to fail with “Document file not found.” The lookup should stay within the installed package (e.g., Path(__file__).parent) or use package resources so the command works after installation.

Useful? React with 👍 / 👎.

@sasmith sasmith added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit c9a23d6 Nov 19, 2025
32 checks passed
@sasmith sasmith deleted the sasmith-11-19-add_a_technical_manual_etc branch November 19, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants